Skip to content

fix(DataList): Go back to first-of-type approach for padding#3294

Merged
codecademydev merged 2 commits into
mainfrom
kl-gmt-1544-datalist-padding-back-on-th-td
Mar 25, 2026
Merged

fix(DataList): Go back to first-of-type approach for padding#3294
codecademydev merged 2 commits into
mainfrom
kl-gmt-1544-datalist-padding-back-on-th-td

Conversation

@LinKCoding
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding commented Mar 19, 2026

Overview

Applies padding to td and th of List, DataList, and DataTable through first-of-type CSS rules.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1544
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

To be compared against: #3277

  1. Go to DataList see that the spacing is all the same
  2. The Header row should still have the headers aligned with the checkbox, and check for the "Non-selectable rows" story to see that the Headers are bottom aligned
  3. Check that DataTable looks the same
  4. Check that List all looks the same
  5. ...
  6. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Mono Mono PR

@LinKCoding LinKCoding changed the title go back to first-of-type approach fix(DataList): Go back to first-of-type approach for padding Mar 19, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 19, 2026

View your CI Pipeline Execution ↗ for commit a6855b8


☁️ Nx Cloud last updated this comment at 2026-03-25 16:16:11 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.19%. Comparing base (502f9c6) to head (a6855b8).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3294      +/-   ##
==========================================
- Coverage   89.77%   89.19%   -0.59%     
==========================================
  Files         376      250     -126     
  Lines        5586     4701     -885     
  Branches     1777     1560     -217     
==========================================
- Hits         5015     4193     -822     
+ Misses        562      500      -62     
+ Partials        9        8       -1     
Flag Coverage Δ
main ?
pull-request 89.19% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LinKCoding LinKCoding marked this pull request as ready for review March 19, 2026 20:43
@LinKCoding LinKCoding requested a review from a team as a code owner March 19, 2026 20:43
@codecademydev
Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

@codecademy/gamut@68.2.1-alpha.610ec2.0
@codecademy/gamut-kit@0.6.591-alpha.610ec2.0

@github-actions
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding added the Ship It :shipit: Ready 2 ship label Mar 25, 2026
@codecademydev codecademydev merged commit f0dd919 into main Mar 25, 2026
23 of 24 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Ready 2 ship label Mar 25, 2026
@codecademydev codecademydev deleted the kl-gmt-1544-datalist-padding-back-on-th-td branch March 25, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants