Fixed cache time calculation for shortcode#1280
Open
girishpanchal30 wants to merge 2 commits into
Open
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Contributor
|
Plugin build for 6edb2ac is ready 🛎️!
Note You can preview the changes in the Playground |
There was a problem hiding this comment.
Pull request overview
Aligns lazy-loaded shortcode output caching with the configured refresh interval.
Changes:
- Reuses a helper for lazy cache keys.
- Calculates transient lifetime from
refresh. - Supports singular and plural refresh units.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
includes/abstract/feedzy-rss-feeds-admin-abstract.php |
Updates lazy cache lifetime and refresh parsing. |
phpstan-baseline.neon |
Removes resolved static-analysis exceptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+609
to
+610
| $cache_time = $this->calculate_cache_time( $sc['refresh'] ); | ||
| set_transient( $lazyload_cache_key, $content, apply_filters( 'feedzy_lazyload_cache_time', $cache_time, $feed_url ) ); |
Soare-Robert-Daniel
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calculate the cache time and set the transient for the lazy-loaded content based on the shortcode attributes and feed URL.
Check before Pull Request is ready:
Closes #1279