Enhanced feed URL validation#1282
Open
girishpanchal30 wants to merge 2 commits into
Open
Conversation
pirate-bot
added
the
pr-checklist-complete
Contributor
|
Plugin build for f0bbe09 is ready 🛎️!
Note You can preview the changes in the Playground |
There was a problem hiding this comment.
Pull request overview
Enables authenticated feed URLs to pass SSRF validation while preserving credentials for import.
Changes:
- Validates a credential-free URL while retaining the original authenticated URL.
- Adds regression and SSRF tests for authenticated feeds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
includes/abstract/feedzy-rss-feeds-admin-abstract.php |
Adds authenticated URL validation. |
tests/test-admin-abstract.php |
Adds validation and normalization coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Soare-Robert-Daniel
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validated the feed URL without the authentication credentials. If the feed URL is valid, the original Basic Authentication feed URL is used to import the feed.
Check before Pull Request is ready:
Closes #1281