fix(tests): remove duplicate _registry_rows() definition in test_billing.py

[Coding-Dev-Tools]

Trivial fix: removes the duplicate _registry_rows() function definition (ruff F811). The second definition at line 752 was identical to the first at line 739 — a merge artifact from PR #25. Supersedes the same fix in PR #26.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[Coding-Dev-Tools]

Council Gate Verdict: APPROVE

Confidence: 1.0 | Agreement: 100% | Avg Overall: 4.84/5.0

Reviewer	Overall	Recommendation
qwen38-orchestrator	4.8	approve
qwen38-coder	4.8	approve
qwen38-reviewer	5.0	approve
qwen38-security	5.0	approve
qwen38-tester	4.6	approve_with_nits

Summary: Removes a shadowed duplicate _registry_rows() definition (dead code — Python uses the last definition in a module). Test-only change, CI fully green (7 SUCCESS, 1 SKIPPED), no production code touched, no coverage lost.

Tester nit: PR description says "the kept (later) definition" but the diff removes the later duplicate, activating the earlier one. Functional outcome validated by passing CI — documentation nit only.

Session: council-94ca5ad4-34ff-4c91-ab57-31a6efce4f4a

[Coding-Dev-Tools]

Council Merge Review — APPROVE

PR: Coding-Dev-Tools/engraphis#32
Council session: council-cb7ab8ec-db17-4dcc-b1a5-0e9c390d9776
Decision metrics: 5 completed reviewers; 100% agreement; 5.00/5 average

Evidence reviewed

• 1 changed file paths and 770 diff characters supplied to each council member.
• GitHub snapshot: mergeable=MERGEABLE, mergeStateStatus=BLOCKED, reviewDecision=REVIEW_REQUIRED.
• Files: tests/test_billing.py (+0/-13)
• Checks: test + lint (full offline stack) (3.10): SUCCESS; test + lint (full offline stack) (3.11): SUCCESS; test + lint (full offline stack) (3.12): SUCCESS; core floor (numpy-only, Python 3.9): SUCCESS; browser accessibility smoke: SUCCESS; docker smoke — path gate: SUCCESS; build + install wheel: SUCCESS; docker build + health smoke: SKIPPED

Model council and weighting

Model	Effective vote share	Recommendation	Effective score	Call
qwen38-orchestrator	20.0%	APPROVE	5.00/5	success
qwen38-coder	20.0%	APPROVE	5.00/5	success
qwen38-reviewer	20.0%	APPROVE	5.00/5	success
qwen38-security	20.0%	APPROVE	5.00/5	success
qwen38-tester	20.0%	APPROVE	5.00/5	success
nemotron3-architect	0.0%	NO VOTE	n/a	provider_error

Weighted outcome: 5.00/5.00 completed voting weight approved (100.0% weighted agreement).

Root-cause and correctness assessment

The diff is a purely subtractive -13-line removal of the second identical _registry_rows() definition in tests/test_billing.py (lines 752-764), a merge artifact from PR #25. Python resolves the last definition in a module, so the remaining first definition is byte-for-byte equivalent in behavior. All seven CI checks pass across Python 3.9-3.12. Zero production or security surface. Resolves ruff F811.

Gaps and residual risks

• No residual risk was identified from the supplied evidence.

Required action

• No code change is required by the council verdict.

Merge status

• Council APPROVE granted. Merge blocked by branch protection (REVIEW_REQUIRED). Awaiting approving GitHub review to proceed.

Posted automatically by the evidence-backed council merge gate.

[Coding-Dev-Tools]

Council Merge Review — APPROVE

PR: Coding-Dev-Tools/engraphis#32
Council session: council-e4908c20-22e2-4d86-b859-dffaff4cd283
Decision metrics: 5 completed reviewers; 100% agreement; 4.93/5 average

Evidence reviewed

• 1 changed file paths and 769 diff characters supplied to each council member.
• GitHub snapshot: mergeable=MERGEABLE, mergeStateStatus=BLOCKED, reviewDecision=REVIEW_REQUIRED.
• Files: tests/test_billing.py (+0/-13)
• Checks: test + lint (full offline stack) (3.10): SUCCESS; (3.11): SUCCESS; (3.12): SUCCESS; core floor (numpy-only, Python 3.9): SUCCESS; browser accessibility smoke: SUCCESS; docker smoke — path gate: SUCCESS; build + install wheel: SUCCESS; docker build + health smoke: SKIPPED

Model council and weighting

Model	Recommendation	Effective score	Call
qwen38-orchestrator	APPROVE	5.00/5	success
qwen38-coder	APPROVE	5.00/5	success
qwen38-reviewer	NO VOTE	n/a	invalid_output
qwen38-security	APPROVE	4.80/5	success
qwen38-tester	APPROVE	4.80/5	success
nemotron3-architect	APPROVE	5.00/5	success

• Weighted outcome: 5.00/5.00 completed voting weight approved (100.0% weighted agreement); weighted overall score 4.93/5.

Root-cause and correctness assessment

The diff mechanically removes the second (shadowing) definition of _registry_rows() in tests/test_billing.py. Both definitions are logically identical, so eliminating the duplicate introduces zero behavioral change. CI is green across Python 3.9 (numpy-only floor), 3.10, 3.11, and 3.12, plus lint, wheel build, and smoke checks. The change is test-only (+0/-13), touches no production surface, and reduces dead code. Squash merge is appropriate for this single-file, single-hunk fix.

Merge status

• Council verdict: APPROVE (clean).
• GitHub merge attempt: BLOCKED by base-branch policy (reviewDecision=REVIEW_REQUIRED). The normal non-admin merge was refused; per fleet policy this was NOT forced with --admin. An approving human/bot review is required to satisfy branch protection before merge.

Posted automatically by the evidence-backed council merge gate.

[Coding-Dev-Tools]

Superseded by #34, which includes this _registry_rows() dedup alongside the soft-close restore + dead-code removal. Closing as folded-in.