fix(ci): skip commercial workflows gracefully when production secrets are unconfigured#42
Merged
Merged
Conversation
… are unconfigured The production-synthetics workflow runs hourly and fails every time because ENGRAPHIS_CUSTOMER_URL and related secrets are not yet set on this repo. Add a job-level if guard so scheduled runs show as 'skipped' (green) instead of failing, reducing noise until production deployment is configured. Same guard applied to commercial-backup.yml (daily 03:41 UTC).
…te in commercial-backup.yml The `secrets` context is not available in job-level `if` expressions in GitHub Actions. Replace with a step-level gate pattern (matching production-synthetics.yml) that checks env vars populated from secrets and sets a skip output for downstream steps.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both
commercial-backup.ymlandproduction-synthetics.ymlfail hard when production secrets are not yet configured (pre-GA repos). The original branch attempt usedsecretscontext in a job-levelifexpression, which is invalid in GitHub Actions — thesecretscontext is only available in step-levelrun/ifcontexts.Fix
skip=trueoutput. All downstream steps getif: steps.gate.outputs.skip != 'true'.if: ${{ secrets.ENGRAPHIS_CUSTOMER_URL != '' }}job-level condition.Both workflows now emit a
::warning::annotation and exit cleanly (green) when secrets are missing, instead of failing with cryptic errors.