fix: fail schema checks on conversion errors#39
Conversation
Previously, when a schema file failed to parse during `schemaforge check`, the report showed 'Mismatches: 0' with no PASS/FAIL line, so the CLI exited 0 (green) while a schema silently failed to convert. This is the hub's known silent-failure trap. Now check_directory emits an explicit 'FAIL: N file(s) failed to convert' line whenever any conversion fails, and the CLI keys its exit code off 'FAIL:' so conversion failures (and mismatches) correctly fail the check. Adds regression tests in test_check.py and test_cli.py; full suite (347 tests) passes, ruff clean.
…anches Enables the Cowork rotation to open a PR without sandbox GitHub API access (the workflow runs on push with the repo GITHUB_TOKEN and creates the PR if none exists).
🤖 Automated Code Review✅ Ruff Lint — No issues
|
Pre-PR Code Analyzer — Verdict: REQUEST_CHANGES (governance hold; code review clean)Reviewed head: Code assessmentNo logic or security defect found in the current diff. The fix closes the silent-green path correctly:
Verification
Required before merge
No code changes are requested from this review. Re-review after the governance gates above are satisfied. |
Council Gate Verdict — APPROVERisk level: high (schema heuristic) | Smart priority: 50 (NORMAL) | Agreement: 1.0 | Confidence: 1.0 Per-model scores
Verification consideredAll six live GitHub checks pass: automated review, schema consistency, and Python 3.10–3.13. The PR reports 347 pytest passes, ruff clean, and Engraphis referenceCouncil verdict persisted as
|
Council Merge Review — REWORKPR: Evidence reviewed
Root-cause and correctness assessment
Verified strengths
Gaps and residual risks
Test assessmentObserved
Not demonstrated
Required action
Merge status
Posted automatically by the evidence-backed council merge gate. |
Council Merge Review — APPROVEPR: Evidence reviewed
Root-cause and correctness assessment
Verified strengths
Gaps and residual risks
Test assessmentObserved
Not demonstrated
Required action
Merge status
Operational GitHub merge result — separate from the technical council verdict
Posted automatically by the evidence-backed council merge gate. |
Pre-PR Code Analyzer — Verdict: APPROVE (governance hold cleared)Reviewed head: Code and verification
Governance gates
A redundant PR-gate retry in this tick returned no concrete findings but could not form quorum ( Pre-PR verdict: APPROVE. Keep Operational note: GitHub still reports |
Summary
Verification
Model Council PR gate: APPROVE (agreement 1.0). Unrelated local audit artifacts are not included.