Skip to content

Launch ComfyUI with Desktop2 frontend assets#1124

Open
benceruleanlu wants to merge 4 commits into
bl/mar-240-desktop-telemetry-bridgefrom
bl/desktop2-frontend-root
Open

Launch ComfyUI with Desktop2 frontend assets#1124
benceruleanlu wants to merge 4 commits into
bl/mar-240-desktop-telemetry-bridgefrom
bl/desktop2-frontend-root

Conversation

@benceruleanlu

Copy link
Copy Markdown
Member

Summary

  • resolve comfyui_frontend_package/static-desktop2 from the selected ComfyUI Python environment
  • inject Desktop-managed --front-end-root for local ComfyUI launches
  • replace any user-supplied --front-end-root so Desktop owns this launch plumbing

Tests

  • pnpm exec vitest run src/main/lib/desktopFrontendRoot.test.ts
  • pnpm run typecheck
  • pnpm run lint
  • pnpm run build
  • pnpm run test

Note: repo-wide pnpm run format currently fails on an existing malformed src/renderer/src/components/DetailSection.vue; this PR was formatted only on touched files.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0be88f85-05aa-4ea5-b3d4-f1302e0e5a44

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bl/desktop2-frontend-root
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch bl/desktop2-frontend-root

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kosinkadink

Copy link
Copy Markdown
Member

Is this meant to be just an example if we were to go the 'custom frontend build for desktop' route, since its marked as draft?

@benceruleanlu benceruleanlu marked this pull request as ready for review June 17, 2026 02:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a463658f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main/lib/desktopFrontendRoot.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants