Launch ComfyUI with Desktop2 frontend assets#1124
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Is this meant to be just an example if we were to go the 'custom frontend build for desktop' route, since its marked as draft? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a463658f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Amp-Thread-ID: https://ampcode.com/threads/T-019ed377-5593-70ae-bb78-2aaa81e5c613 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019ed377-5593-70ae-bb78-2aaa81e5c613 Co-authored-by: Amp <amp@ampcode.com>
Summary
comfyui_frontend_package/static-desktop2from the selected ComfyUI Python environment--front-end-rootfor local ComfyUI launches--front-end-rootso Desktop owns this launch plumbingTests
pnpm exec vitest run src/main/lib/desktopFrontendRoot.test.tspnpm run typecheckpnpm run lintpnpm run buildpnpm run testNote: repo-wide
pnpm run formatcurrently fails on an existing malformedsrc/renderer/src/components/DetailSection.vue; this PR was formatted only on touched files.