fix(telemetry): address CodeRabbit review from #1132

[deepme987]

Description

Follow-ups to the install → boot → canvas instrumentation merged in #1132. CodeRabbit posted four actionable comments after that PR was squash-merged, so they land here. All are side-channel hardening — no change to the funnel events themselves.

1. canvasEntry.ts — clamp server_ready_to_canvas_ms to >= 0. Date.now() can move backward (clock skew), which would emit a negative, funnel-polluting duration. Math.max(0, …).
2. installer.withInstallPhase — isolate the onPhase tap. The phase tap is documented side-channel-only, but a throwing onPhase could abort or mask an install. Each invocation is now wrapped in try/catch (safeOnPhase).
3. install.emitInstallPhase — guard classification/emission. Telemetry bucketing/emit is wrapped so a failure can't derail a post-install phase (this function is also the installer's onPhase tap, so this guards both paths).
4. useCloudCapacity.test.ts — fix the loadComposable return type. Awaited<ReturnType<typeof importComposable>> resolved to the composable function; the value assigned is its call result. Now ReturnType<Awaited<ReturnType<typeof importComposable>>>, matching the inner composable declaration.

How has this been tested?

• typecheck:node + typecheck:web — clean.
• vitest run on canvasEntry.test.ts, bootPhaseBuffer.test.ts, useCloudCapacity.test.ts — 33 passing.

Related

Follow-up to #1132 (merged). Resolves the four CodeRabbit threads on that PR.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 52227200-250d-401d-b523-57f2d605f83c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch deepme987/desktop/telemetry-review-followups

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch deepme987/desktop/telemetry-review-followups

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}