Open
Conversation
Enorovan
force-pushed
the
constant-text-fade-duration
branch
from
49da004 to
4e4c6e4
Compare
PringlesGang
requested changes
Apr 8, 2026
Member
PringlesGang
left a comment
PringlesGang
left a comment
There was a problem hiding this comment.
Overall structure is quite good
…add duration helper methods
Enorovan
force-pushed
the
constant-text-fade-duration
branch
from
4e4c6e4 to
0830b05
Compare
…on and add duration helper methods
Enorovan
force-pushed
the
constant-text-fade-duration
branch
from
47a4ced to
5a4ac9d
Compare
PringlesGang
requested changes
Apr 13, 2026
Member
PringlesGang
left a comment
PringlesGang
left a comment
There was a problem hiding this comment.
The glyph start progress should be dependent on TextSpeed, and their end progress should be an offset away from that starting progress depending on TextFadeInDuration and the currently predicted remaining duration of the line, such that it ends TextFadeInDuration seconds after the beginning progress
| if (glyphCount == 0 || totalProgress <= 0.0f) return {0.0f, 1.0f}; | ||
|
|
||
| const size_t parallelBlockGlyphNo = glyph - block.Start; | ||
| const float glyphFadeProgress = std::min(TextFadeInDuration, totalProgress); |
Member
There was a problem hiding this comment.
TextFadeInDuration is in seconds and totalProgress is an arbitrary basis? glyphFadeProgress is completely meaningless like this
…on and add duration helper methods
Enorovan
force-pushed
the
constant-text-fade-duration
branch
from
278573b to
b64b6e7
Compare
…on and add duration helper methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.