Upgrade Squad sample Copilot/MAF dependency chain - #1485
Open
tamirdresher wants to merge 7 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1485Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1485" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Squad sample’s Copilot/MAF dependency chain so the sample’s MAF adapter and GitHub.Copilot.SDK resolve consistently, avoiding mismatched Copilot SDK artifacts after the SDK’s split of CopilotClient into a separate assembly.
Changes:
- Pin
GitHub.Copilot.SDKcentrally to1.0.8and bumpSquad.Agents.AIto0.5.6-preview.23. - Add an explicit
Microsoft.Agents.AI.GitHub.Copilotreference to the Squad sample ApiApp. - Add an ApiApp property to steer the MAF buildTransitive bridge to the intended Copilot SDK version, and exclude SDK build assets to avoid duplicate target imports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/squad/CommunityToolkit.Aspire.Hosting.Squad.ApiApp/CommunityToolkit.Aspire.Hosting.Squad.ApiApp.csproj | Pins the sample’s Copilot/MAF package set and forces the MAF bridge onto the intended Copilot SDK version. |
| Directory.Packages.props | Updates central package pins for the Squad sample’s Copilot SDK and agent adapter dependencies. |
Comment on lines
+3
to
+9
| <PropertyGroup> | ||
| <!-- MAF 1.15.0-rc1 still defaults its buildTransitive bridge to GitHub.Copilot.SDK | ||
| 1.0.5. Force the bridge to the newer 1.0.8 SDK path that Squad.Agents.AI | ||
| already restores transitively so the split CopilotClient assembly + CLI | ||
| land from the same SDK version without duplicate target imports. --> | ||
| <_MicrosoftAgentsAICopilotSdkVersion>1.0.8</_MicrosoftAgentsAICopilotSdkVersion> | ||
| </PropertyGroup> |
Comment on lines
+80
to
+83
| <!-- Keep an explicit GitHub.Copilot.SDK pin for the Squad sample so the split | ||
| CopilotClient assembly and native CLI payload always resolve from the | ||
| same SDK version we validate locally/CI. --> | ||
| <PackageVersion Include="GitHub.Copilot.SDK" Version="1.0.8" /> |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This reverts commit faff442.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tamirdresher
enabled auto-merge
July 31, 2026 11:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1496
Summary
GitHub.Copilot.SDKpin from 1.0.3 to 1.0.8Squad.Agents.AIfrom 0.5.1-preview.16 to 0.5.6-preview.23Microsoft.Agents.AI.GitHub.Copilot1.15.0-rc1 reference for the sample ApiApp/askso the sample accepts eitherpromptorpromptspayloads and returns a clean 400 for empty inputWhy
CommunityToolkit.Aspire.Hosting.Squadis the canonical upstream home of this Aspire integration. The old blocked SDK-only bump (seebradygaster/squad#1449, and the direct Dependabot follow-ups here such as #1463/#1472/#1477) failed because newer Copilot SDK builds splitCopilotClientinto a separate assembly while the published MAF adapter still defaulted its buildTransitive import to an older SDK path.This PR upgrades the sample's full Squad/MAF/Copilot stack together instead of only bumping the direct SDK pin.
PR Checklist
Validation
dotnet build .\\examples\\squad\\CommunityToolkit.Aspire.Hosting.Squad.AppHost\\CommunityToolkit.Aspire.Hosting.Squad.AppHost.csproj -c Releasedotnet build .\\tests\\CommunityToolkit.Aspire.Hosting.Squad.Tests\\CommunityToolkit.Aspire.Hosting.Squad.Tests.csproj -c ReleaseCommunityToolkit.Aspire.Hosting.Squad.Testssuite passed twice locally after the final polish changesdotnet list .\\examples\\squad\\CommunityToolkit.Aspire.Hosting.Squad.ApiApp\\CommunityToolkit.Aspire.Hosting.Squad.ApiApp.csproj package --include-transitive/,/swagger/v1/swagger.json, and/ask?squad=dev|researchall returned live responsesOther information
CONTRIBUTING.mdor.githubpublish-azure-artifactsandrun-tests / noopare expected skipped checks for this PR