Skip to content

feat: Add unit tests for events-players spec#96

Open
rubenvdlinde wants to merge 1 commit intodevelopmentfrom
feature/events-players
Open

feat: Add unit tests for events-players spec#96
rubenvdlinde wants to merge 1 commit intodevelopmentfrom
feature/events-players

Conversation

@rubenvdlinde
Copy link
Copy Markdown
Contributor

Summary

  • Add 21 unit tests verifying the events-players spec requirements
  • CharacterServiceTest: 8 tests for event effect application (EVT-008, EVT-020-023)
  • EventTest: 7 tests for Event entity serialization (EVP-010-012)
  • PlayerTest: 6 tests for Player entity serialization (EVP-015, PLR-001-008)
  • OpenSpec change artifacts documenting the implementation

Test plan

  • All 21 unit tests pass locally via php vendor/bin/phpunit
  • Tests cover event effect stacking, missing event graceful handling, effect application order
  • Tests verify Event uses title not name (EVP-010)
  • Tests verify Player skeletal model with 3 fields (EVP-015)

Add 21 unit tests verifying events and players spec requirements:
- CharacterServiceTest: event effect application, stacking, missing events
- EventTest: entity serialization, title field, userId, hydration
- PlayerTest: entity serialization, name/description, hydration
Base automatically changed from feature/enrich-openspec-specs to development March 23, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant