Added back-end unit tests for all controllers, services and more#593
Draft
WilcoLouwerse wants to merge 25 commits intodevelopmentfrom
Draft
Added back-end unit tests for all controllers, services and more#593WilcoLouwerse wants to merge 25 commits intodevelopmentfrom
WilcoLouwerse wants to merge 25 commits intodevelopmentfrom
Conversation
WilcoLouwerse
commented
Aug 29, 2025
| $logs = $this->synchronizationLogMapper->findAll(null, null, $filters); | ||
|
|
||
| // Create CSV content | ||
| $csvData = "ID,UUID,Level,Message,Synchronization ID,User ID,Session ID,Created,Expires\n"; |
Contributor
Author
There was a problem hiding this comment.
Synchronizations don't have a property called level
WilcoLouwerse
commented
Aug 29, 2025
| @@ -0,0 +1,2 @@ | |||
| [submodule "3rdparty"] | |||
| shallow = true | |||
WilcoLouwerse
commented
Aug 29, 2025
| * @param string $reference The reference to find sources for | ||
| * @return array<Source> Array of Source entities | ||
| */ | ||
| public function findByRef(string $reference): array |
Contributor
Author
There was a problem hiding this comment.
@rubenvdlinde ik kan op OpenConnector geen Sources meer importeren omdat de findByRef function op de SourceMapper niet meer bestaat
Is dit intentional? Of mag ik deze functie terug zetten?
WilcoLouwerse
changed the title
Member
|
PR converted to draft to serve as inspiration for refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://conduction.atlassian.net/browse/CONNECTOR-371
docker exec master-nextcloud-1 bash -c "cd /var/www/html && phpunit --bootstrap tests/bootstrap.php apps-extra/openconnector/tests"