feat: Extract MetricsService and add endpoint/job/mapping metrics#695
Open
rubenvdlinde wants to merge 1 commit intofeature/enrich-openspec-specsfrom
Open
feat: Extract MetricsService and add endpoint/job/mapping metrics#695rubenvdlinde wants to merge 1 commit intofeature/enrich-openspec-specsfrom
rubenvdlinde wants to merge 1 commit intofeature/enrich-openspec-specsfrom
Conversation
- Extract metric collection from MetricsController into MetricsService (ADR-008) - Add openconnector_endpoints_total gauge metric - Add openconnector_jobs_total and openconnector_job_runs_total metrics - Add openconnector_mappings_total and openconnector_rules_total metrics - Add unit tests for MetricsService, MetricsController, HealthController - Add Newman API test collection for metrics/health endpoints - Add administrator documentation for Prometheus scrape configuration Implements: openspec/specs/prometheus-metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #694
Spec Reference
openspec/specs/prometheus-metrics/spec.mdTest plan
MetricsServiceTest,MetricsControllerTest,HealthControllerTest)curl /api/metricsreturns all 11 metric types