fix: Resolve CI failures in stylelint, PHPUnit, and Newman#198
Open
rubenvdlinde wants to merge 5 commits intodevelopmentfrom
Open
fix: Resolve CI failures in stylelint, PHPUnit, and Newman#198rubenvdlinde wants to merge 5 commits intodevelopmentfrom
rubenvdlinde wants to merge 5 commits intodevelopmentfrom
Conversation
…ified ones Remove @SuppressWarnings(PHPMD.StaticAccess) from 13 service classes that have no actual static method calls. Keep with explanation on SymfonyEmailService and SettingsService (Transport::fromDsn) and dashboard widget (Util::addScript).
Remove 10 unnecessary class-level UnusedFormalParameter suppressions from classes with no actual unused parameters. Move class-level suppression on SettingsController, ArchiMateImportService, and SoftwareCatalogueService to method-level annotations on the specific methods that need them.
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (120 total)
npm dependencies (582 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (120 total)
npm dependencies (582 total)
PHPUnit Tests
Code coverage: 0% (0 / 270 statements) Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (120 total)
npm dependencies (582 total)
PHPUnit Tests
Code coverage: 0% (0 / 270 statements) Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (120 total)
npm dependencies (582 total)
PHPUnit Tests
Code coverage: 0% (0 / 270 statements) Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
rjzondervan
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan