Reject embedded images in connector docs MDX lint#101
Merged
Conversation
kans
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Connector docs (
docs/connector.mdx) are compiled to HTML by the registry's React MDX renderer. An embedded image makes React emit a<link rel="preload">tag, and the registry's server-side HTML validator blockslinkas a disallowed tag — so the docs-publish cron returns a 400 and wedges. It is also against team convention for connector docs to embed repo-local images. Rejecting embedded images at lint time catches this statically and fast, with no rendering.What this changes
image() andimageReference(![alt][ref]) mdast node types. Theimagenode was previously only URL-checked alongsidelink/definition; it is now failed outright.<img>was already rejected (not in the allowed component/element sets), so this closes the remaining markdown-syntax gap.All 32 tests pass.