Remove legacy release recording lambdas#69
Merged
Conversation
ggreer
approved these changes
May 6, 2026
gontzess
added a commit
that referenced
this pull request
May 6, 2026
**Why** Connector release images no longer need to be published to GHCR. Keeping the GHCR path means extra registry auth, extra image metadata, and extra attestation verification for an output that is no longer consumed. **What this changes** - Removes the GHCR image from the Docker GoReleaser template. - Removes GHCR login from Docker publishing and release verification. - Records only ECR Public image metadata for public Docker images. - Removes GHCR image attestation verification from the release validation script. - Updates release workflow docs, protobuf comments, and the workflow diagram. **Validation** - `go test ./...` - `git diff --check` - YAML parse for `.github/workflows/release.yaml` - Rendered `.goreleaser-docker-oci-template.yaml.tmpl` with sample values and parsed it as YAML - `make protogen` - `make docs` - Live release `v0.1.122-test.8`: Docker enabled, no GHCR login step, ECR Public publish, manifest publication, registry API recording, and release verification passed - Rebased onto `main` after #69 merged; reran `go test ./...`, `git diff --check`, and YAML parse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release metadata is now recorded through the connector registry API. The older Lambda recording paths still wrote to deprecated release tables and kept the shared workflow coupled to systems that are no longer the source of truth.
The registry API also expects Lambda image metadata when a connector publishes a Lambda image. Removing the old Lambda registry job means the release manifest must carry that metadata directly.
What this changes
record-lambda-registryjob.lambda-arm64in the release manifest.docker_digestoutput for Lambda builds so the workflow can capture the pushed Lambda image digest.record-connector-registrytopublish-release-manifest.record-registry-apidepend on the manifest publication job only.publish-release-manifestandrecord-registry-apiseparate so dist publication and registry API ingest remain distinct failure points.Validation
go test ./...git diff --checkmake docs.github/workflows/release.yamlv0.1.122-test.5: Lambda-only, passed throughrecord-registry-apiv0.1.122-test.6: Docker plus Lambda, passed throughrecord-registry-apiv0.1.122-test.7: renamedpublish-release-manifest,record-registry-api, andverify-releasepassed