Skip to content

Align PR review summaries with deterministic state#81

Closed
gontzess wants to merge 1 commit into
mainfrom
gontzess/pr-review-parity
Closed

Align PR review summaries with deterministic state#81
gontzess wants to merge 1 commit into
mainfrom
gontzess/pr-review-parity

Conversation

@gontzess

@gontzess gontzess commented May 20, 2026

Copy link
Copy Markdown
Contributor

Why

The PR review workflow needs the same deterministic summary/state handling that landed in the related workflow repo. This keeps incremental reviews from trusting model-written legacy state and adds effective interdiff handling for base drift or diverged compares.

What this changes

  • Posts review summaries from an owned finalizer instead of having the model create or edit them
  • Requires run_id before a previous marker is trusted for incremental or interdiff mode
  • Adds same-repo effective interdiff and unchanged modes, with full review fallback
  • Keeps separate connector/general summary headings
  • Adds focused tests for state parsing, interdiff handling, and finalizer behavior

Validation

  • Local Python tests, Python compile checks, YAML parsing, and git diff --check passed
  • Cross-review completed with no new blocking findings
  • Private canary PR testing passed for connector full, incremental, unchanged, and interdiff modes
  • Private canary PR testing passed for the general review profile and summary heading

Draft while final review is pending.

@gontzess
gontzess marked this pull request as ready for review May 20, 2026 19:12
@gontzess
gontzess enabled auto-merge (squash) May 20, 2026 19:14
@gontzess
gontzess requested a review from a team May 20, 2026 19:18
@gontzess
gontzess disabled auto-merge May 20, 2026 22:48
@gontzess gontzess closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant