Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts tappAS runtime path handling to prefer a user-specific hidden directory under the user’s home folder and cleans up loadRscriptPath() to avoid an unused/shadowing local variable.
Changes:
- Updated
DataApp.appRunPathto point to~/.tappasinstead of the current working directory. - Commented out an unused
rscriptPathlocal variable inloadRscriptPath()(avoids shadowing the class field).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+205
to
+206
| //private final String appRunPath = System.getProperty("user.dir"); | ||
| private final String appRunPath = Paths.get(System.getProperty("user.home"), ".tappas").toString(); |
| if(Files.exists(Paths.get(getRScriptOverwriteFilepath()))) { | ||
| List<String> lines = Files.readAllLines(Paths.get(getRScriptOverwriteFilepath()), StandardCharsets.UTF_8); | ||
| String rscriptPath = ""; | ||
| //String rscriptPath = ""; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way the application determines its runtime path and includes a minor code cleanup. The most significant change is that the application now uses a dedicated directory in the user's home folder for its runtime path, which improves user data management and avoids cluttering the working directory.
Application path management:
appRunPathinDataApp.javato use a.tappasdirectory in the user's home folder instead of the current working directory. This helps keep application files organized and user-specific.Code cleanup:
rscriptPath) in theloadRscriptPathmethod for clarity.