-
Notifications
You must be signed in to change notification settings - Fork 0
feat(hris): durable onboarding saga (Temporal) — Phase 5a #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5543cb0
feat(hris): durable onboarding saga (Temporal) — Phase 5a
intech dfe46a6
docs(hris): document the onboarding saga + add the `saga` compose pro…
intech 0ab54b7
docs(hris): sync docstrings + README with the five-service topology
intech 7a18140
docs(examples): hris index row — durable onboarding saga with Temporal
intech de7fb15
docs(hris): drop internal ADR-001 citation from onboardingStatus comment
intech 605b3b3
refactor(hris): harden the onboarding saga (CodeRabbit Major findings)
intech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,10 @@ | ||
| allowBuilds: | ||
| '@bufbuild/buf': true | ||
| esbuild: true | ||
| # @swc/core compiles the Temporal workflow bundle (@temporalio/worker bundles | ||
| # src/temporal/workflows.ts with swc at worker startup — no separate build). | ||
| '@swc/core': true | ||
| # protobufjs is pulled transitively by @temporalio's gRPC client | ||
| # (@grpc/grpc-js → @grpc/proto-loader → protobufjs). Allow its build so pnpm | ||
| # does not report ERR_PNPM_IGNORED_BUILDS on install. | ||
| protobufjs: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package access.v1; | ||
|
|
||
| import "google/protobuf/empty.proto"; | ||
|
|
||
| // AccessService provisions and revokes system access (the IT side of | ||
| // onboarding). It is a leaf service with an in-memory account ledger — the | ||
| // onboarding saga's fourth forward step. | ||
| service AccessService { | ||
| // ProvisionAccess creates the employee's system account. Idempotent: | ||
| // re-provisioning returns the existing account. Onboarding saga step 4. | ||
| rpc ProvisionAccess(ProvisionAccessRequest) returns (ProvisionAccessResponse) {} | ||
|
|
||
| // RevokeAccess removes the employee's system account (the ProvisionAccess | ||
| // compensation). Idempotent; a no-op for an unknown employee. | ||
| rpc RevokeAccess(RevokeAccessRequest) returns (google.protobuf.Empty) {} | ||
| } | ||
|
|
||
| message ProvisionAccessRequest { | ||
| string employee_id = 1; | ||
| // Work email the account is keyed on. | ||
| string email = 2; | ||
| } | ||
|
|
||
| message ProvisionAccessResponse { | ||
| Access access = 1; | ||
| } | ||
|
|
||
| message RevokeAccessRequest { | ||
| string employee_id = 1; | ||
| } | ||
|
|
||
| message Access { | ||
| string employee_id = 1; | ||
| // The provisioned account handle (e.g. an SSO subject id). | ||
| string account_id = 2; | ||
| // True once an account exists for this employee. | ||
| bool provisioned = 3; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore lockfile-based installs for reproducible images.
At Line 10 and Line 11, dropping
pnpm-lock.yaml+--frozen-lockfilemakes image dependency resolution non-deterministic across builds.Suggested fix
🤖 Prompt for AI Agents