docs(car-sharing): refresh stale 1.1.0 forward-references (now released)#37
Conversation
1.1.0 is published, so "once 1.1.0 is out" no longer reads true. This example still pins @connectum/auth ^1.0.0 (which resolves to 1.0.0) and keeps the `public` workaround, so reword the internal-marker notes to present tense and point the migration at the tracking issue. - README: the OpenAPI overlay note now states 1.1.0 adds the `internal` marker and links the migration to examples#36 (instead of "once 1.1.0 is out"). - scripts/openapi-authz.ts: the two `internal`-marker comments become present- tense (this example targets the 1.0.0 API; on 1.1.0 a method marked `internal` would add x-internal:true). Prose/comments only — no behavior change. Claude-Session: https://claude.ai/code/session_01MdeH7fExPmiRHRirGuvGk3 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated the car-sharing OpenAPI notes and authz script comments to describe the ChangesOpenAPI auth notes updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1.1.0 is published, so the "once 1.1.0 is out" forward-references in car-sharing no longer read true. This example still pins
@connectum/auth^1.0.0(which resolves to 1.0.0) and keeps thepublicworkaround, so the notes are reworded to present tense and theinternal-marker migration is pointed at the tracking issue.internalmarker and links the migration to Examples: 1.1.0 follow-up — broadcast demos, new-feature showcases, deferred items #36 (instead of "once 1.1.0 is out").internal-marker comments become present-tense (this example targets the 1.0.0 API; on 1.1.0 a method markedinternalwould addx-internal: true).Prose/comments only — no behavior change. The "resolves to the 1.0.0 versions" statement is left intact (it is correct:
^1.0.0resolves to 1.0.0).Part of #36.
Summary by CodeRabbit
@connectum/authso the notes now distinguish between v1.0.0 and v1.1.0 behavior.internalmethod marker and its OpenAPI representation.