Fix seedlist revalidation#2
Open
ffox77 wants to merge 2 commits into
Open
Conversation
checkSeedList() short-circuited on a sticky seedListChecked project flag, so once a node passed the check it was never re-validated. Seed list membership is dynamic (the upstream testnet/integrationnet lists rotate and drop nodes), so a node removed upstream kept launching and was only rejected later by the protocol with "not on the seedlist". - Remove the seedListChecked short-circuit; re-validate against the authoritative remote S3 list every run, falling back to the local seedlist file the node mounts when the remote is unreachable. - Refresh the local seedlist on a confirmed match so the node stays current. - selectNetwork() now resets duplicateNodeIdChecked/javaMemoryChecked for single-supported-network projects too (the early-return previously skipped the resets, leaving those checks stale for single-network metagraphs). - Drop the now-dead seedListChecked flag resets. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Cover the seed-list re-validation fix with unit tests: remote hit refreshes the local list, remote miss errors out (the reported bug), re-validation happens regardless of any cached flag, remote-unreachable falls back to the local seedlist, and mainnet validates the local release list without fetching. Adds sinon + @types/sinon for stubbing the configStore/clm singletons and global fetch; the test uses a real temp dir so the seedlist file I/O is exercised for real. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.