Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new Log Entry from Selection #3841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Create new Log Entry from Selection #3841
Changes from all commits
982876fb3e7090a2bed9fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 31 in app/logbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/Messages.java
Make CreateLogEntryFromSelection a static final constant or non-public and provide accessors if needed.
Check warning on line 31 in app/logbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/Messages.java
Make this "public static CreateLogEntryFromSelection" field final
Check warning on line 31 in app/logbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/Messages.java
Rename this field "CreateLogEntryFromSelection" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
Check warning on line 7 in app/logbook/olog/ui/src/main/java/org/phoebus/logbook/olog/ui/write/LogEntryUtils.java
Add a private constructor to hide the implicit public one.
Uh oh!
There was an error while loading. Please reload this page.