Skip to content

Allow symlinks to phoebus.sh#3845

Open
krisztianloki wants to merge 2 commits into
ControlSystemStudio:masterfrom
krisztianloki:Allow-symlinks-to-phoebus.sh
Open

Allow symlinks to phoebus.sh#3845
krisztianloki wants to merge 2 commits into
ControlSystemStudio:masterfrom
krisztianloki:Allow-symlinks-to-phoebus.sh

Conversation

@krisztianloki

Copy link
Copy Markdown
Contributor

Starting Phoebus using a symlink to phoebus.sh is not possible because the detection where Phoebus was installed fails which means the .jar cannot be found.

This PR uses realpath instead of the cd and pwd -P pair to resolve symlinks and convert the path to absolute.

There is another problem if the installation path contains spaces; we need to put ${TOP} inside quotes.

Checklist

  • Testing:
    • The feature has automated tests
    • Tests were run
    • Used phoebus.sh to check if it works for symlinks and paths containing spaces
  • Documentation:
    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

Use realpath to resolve symbolic links to determine where TOP is
Needed if the path contains spaces
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant