ci: centralize Slack webhook onto org-level SLACK_WEBHOOK_OSS_ALERTS#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes this repo onto the CopilotKit org-level secret
SLACK_WEBHOOK_OSS_ALERTS(visibilityall, posts to #oss-alerts), removing reliance on the repo-local bareSLACK_WEBHOOKsecret.This is a pure secret-NAME swap — the repo-local
SLACK_WEBHOOKvalue is the same #oss-alerts webhook, so there is no behavior change and no channel change.Change
.github/workflows/notify-pr.yml:${{ secrets.SLACK_WEBHOOK }}→${{ secrets.SLACK_WEBHOOK_OSS_ALERTS }}(1 line). TheSLACK_WEBHOOKenv-var alias name is retained, so the rest of the step's script is untouched.publish.ymlalready referencessecrets.SLACK_WEBHOOK_OSS_ALERTSand was intentionally left unchanged.Validation
python3 -c "import yaml; yaml.safe_load(...)"— validactionlint— passsecrets.SLACK_WEBHOOKreferences remain in.github/workflows/Follow-up
The now-unused repo-local
SLACK_WEBHOOKsecret will be deleted after merge.