Skip to content

feat: implement notification recall authorization, delivery confirmation, and audit trail#339

Open
najeebullahii wants to merge 3 commits into
Core-Foundry:mainfrom
najeebullahii:contract-Implement-Notification-Recall-Authorization
Open

feat: implement notification recall authorization, delivery confirmation, and audit trail#339
najeebullahii wants to merge 3 commits into
Core-Foundry:mainfrom
najeebullahii:contract-Implement-Notification-Recall-Authorization

Conversation

@najeebullahii

@najeebullahii najeebullahii commented Jun 26, 2026

Copy link
Copy Markdown

Closes #301

Overview

This PR implements the notification recall and delivery confirmation features for the hello-world contract (including complete state coverage and audit trails via Soroban events) and resolves strict linting errors on the frontend dashboard.

What's Changed

🔒 Contract Backend (contract/)

  • State Updates (types.rs): Extended ScheduledNotification metadata to track delivery and recall states (delivered, delivered_at, recalled_by, recalled_at).
  • Core Logic (lib.rs, autoshare_logic.rs): Implemented confirm_notification_delivery and recall_notification with strict sender/admin ownership checks.
  • Audit Trail & Testing: Created NotificationDelivered/NotificationRecalled events and added 18 comprehensive tests using Soroban try_ method patterns.
  • Code Style: Formatted the backend codebase using cargo fmt to comply with CI style enforcement.

💻 Frontend Dashboard (dashboard/)

  • Lint Fixes (ActivityFeed.tsx, EventExplorerPage.tsx): Removed unused _nextAddress callback parameters from the wallet sync hooks to satisfy strict @typescript-eslint/no-unused-vars rules.

Verification Results

  • Backend Tests: cargo test -p hello-world notification_test -- --nocapture 👉 Result: 18 passed; 0 failed
  • Backend Style: Checked and passing via cargo fmt --check
  • Frontend Lint: npm run lint 👉 Result: 0 errors, 0 warnings (Passed successfully)

@drips-wave

drips-wave Bot commented Jun 26, 2026

Copy link
Copy Markdown

@najeebullahii Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Contracts] Implement Notification Recall Authorization

1 participant