feat: implement notification recall authorization, delivery confirmation, and audit trail#339
Open
najeebullahii wants to merge 3 commits into
Conversation
|
@najeebullahii Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #301
Overview
This PR implements the notification recall and delivery confirmation features for the
hello-worldcontract (including complete state coverage and audit trails via Soroban events) and resolves strict linting errors on the frontend dashboard.What's Changed
🔒 Contract Backend (
contract/)types.rs): ExtendedScheduledNotificationmetadata to track delivery and recall states (delivered,delivered_at,recalled_by,recalled_at).lib.rs,autoshare_logic.rs): Implementedconfirm_notification_deliveryandrecall_notificationwith strict sender/admin ownership checks.NotificationDelivered/NotificationRecalledevents and added 18 comprehensive tests using Sorobantry_method patterns.cargo fmtto comply with CI style enforcement.💻 Frontend Dashboard (
dashboard/)ActivityFeed.tsx,EventExplorerPage.tsx): Removed unused_nextAddresscallback parameters from the wallet sync hooks to satisfy strict@typescript-eslint/no-unused-varsrules.Verification Results
cargo test -p hello-world notification_test -- --nocapture👉 Result:18 passed; 0 failedcargo fmt --checknpm run lint👉 Result:0 errors, 0 warnings(Passed successfully)