Laravel 13 + related updates#3
Merged
Merged
Conversation
(Port of CD-LaravelStarterKi:42ffa341)
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the package to support newer Laravel/Testbench/PHPUnit versions (targeting Laravel 13), refreshes CI/test configuration accordingly, and extends RemoteIdentity with a principalName() accessor while changing how email() is derived for remote identities.
Changes:
- Bumps Composer constraints (PHP/Laravel/Testbench/PHPUnit) and adds Composer scripts for common dev/CI tasks.
- Updates PHPUnit/Testbench usage in tests (e.g.,
DefineRouteattribute and stubs) and adjustsphpunit.xmldefaults. - Refactors
RemoteIdentityto addprincipalName()and changeemail()to prefer principal name.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Feature/ShibIdentityManagerTest.php | Updates PHPUnit/Testbench patterns (DefineRoute attribute, stubs) to align with newer tooling. |
| src/DataObjects/RemoteIdentity.php | Adds principalName storage/accessor and changes email() selection logic. |
| phpunit.xml | Updates PHPUnit configuration defaults and caching settings. |
| composer.json | Raises supported PHP/Laravel ranges and adds scripts/config for consistent dev/CI workflows. |
| .github/workflows/phpunit.yml | Updates CI matrix and dependency installation approach for newer Laravel/Testbench. |
| .gitattributes | Adjusts export-ignore rules (no longer ignoring .lando.yml). |
| .editorconfig | Removes JSON-specific indent settings. |
Comments suppressed due to low confidence (1)
src/DataObjects/RemoteIdentity.php:74
email()currently returns$this->principalName ?: $this->email, butprincipalNameis always non-empty for instances created viafromData()(it falls back to$uid). That makes the$emailfield effectively unused and can causeemail()to return non-email identifiers. Adjusting theprincipalNamefallback logic (or adding a guard inemail()to only preferprincipalNamewhen it is actually an email address) would make this behavior consistent with the method docblock.
/**
* Returns the primary email (netid@cornell.edu|cwid@med.cornell.edu) if available, otherwise the alias email.
*/
public function email(): string
{
return $this->principalName ?: $this->email;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
… local login logic
# Conflicts: # src/Listeners/AuthorizeUser.php
Add LivewireAuth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following
To Review: