Remove SvgJSON data type#1720
Open
r-weng wants to merge 6 commits into
Open
Conversation
Coverage Report for CI Build 0Coverage increased (+0.04%) to 58.298%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions13 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
david-yz-liu
reviewed
Jun 1, 2026
| deleteWhere, entityKey, entityVal, insert, insert_, insertMany_, keyToValues, | ||
| selectFirst, selectList, (<-.), (==.)) | ||
| import Database.Tables hiding (paths, shapes, texts) | ||
| import Database.Tables |
Contributor
There was a problem hiding this comment.
Please update the Database.Tables imports you changed so that they explicitly name what's being imported (this will help improve the code quality throughout)
| return (T.concat [firstName, ". ", lastName]) | ||
| parseInstr _ = return "" | ||
|
|
||
| -- | Parse the JSON representation of a graph into its texts, shapes, and paths components. |
Contributor
There was a problem hiding this comment.
Rename to parseGraphComponentsJSON and move this into the graph model file
| let jsonObj = parseGraphJSON jsonStr | ||
| case jsonObj of | ||
| Nothing -> return $ toResponse ("Error" :: String) | ||
| Just svg -> do |
Contributor
There was a problem hiding this comment.
rename svg into components
Contributor
Author
|
I have made the requested changes. I'm not sure if there are any rules for structuring imports (indenting, new lines) I should adhere to though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request removes the
SvgJSONdata type, previously defined inapp/Database/Tables.hs, and refactors any related code to use a tuple of texts, shapes, and paths instead ofSvgJSON. This pull request also createsparseGraphJSON, a helper function used insaveGraphJSONofapp/Controllers/Graph.hsandrunGetGraphJSONTestofbackend-test/Controllers/GraphControllerTests.hs.Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)