Skip to content

Fixes for run_shell.py, chat draft persistency, and BytePlus silent failure#387

Open
makiroll1125 wants to merge 2 commits into
V1.4.1from
fix/shell
Open

Fixes for run_shell.py, chat draft persistency, and BytePlus silent failure#387
makiroll1125 wants to merge 2 commits into
V1.4.1from
fix/shell

Conversation

@makiroll1125

@makiroll1125 makiroll1125 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

What

  • Fix run_shell on Windows so commands with quoted arguments (e.g. claude -p "some prompt") run correctly instead of silently breaking
  • Save chat drafts so they don't disappear when switching tabs and coming back
  • Fix BytePlus so that failed requests (like rate limits) are reported as real errors instead of looking like an empty successful response

Why

Three unrelated bugs that caused confusing, silent failures: shell commands breaking on quoted text, typed messages vanishing on tab switch, and BytePlus errors being swallowed so failures looked identical to empty responses.

Closes #384 , #382

How to test

  • Run a run_shell action with shell: "cmd" and a command containing a quoted argument, e.g. claude -p "test prompt", in both foreground and background mode. Confirm it runs correctly instead of failing or mangling the argument.
  • Type a draft message in the Chat tab, switch to another tab (Settings or Tasks & Actions), then switch back. Confirm the draft is still there.
  • Trigger a BytePlus call that fails (e.g. hits a rate limit). Confirm the failure now shows up as a proper error instead of looking like an empty response.

@makiroll1125
makiroll1125 requested review from ahmad-ajmal and zfoong and removed request for ahmad-ajmal July 17, 2026 05:06
@makiroll1125 makiroll1125 changed the title Fix/shell run_shell.py, chat draft persistency, and BytePlus silent failure fixes Jul 22, 2026
@makiroll1125 makiroll1125 changed the title run_shell.py, chat draft persistency, and BytePlus silent failure fixes Fixes for run_shell.py, chat draft persistency, and BytePlus silent failure Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants