Develop -> main

[CheChe903]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the application's configuration management by transitioning from static, file-based secrets to an environment-variable-driven approach. By removing the private configuration file and integrating standard environment variable patterns across the Spring profiles and Docker setup, the changes enhance security, simplify local development, and streamline containerized deployments.

Highlights

• Configuration Refactoring: Consolidated security and cloud configuration settings into environment-specific YAML files, removing the dependency on a separate private configuration file.
• Environment Variable Integration: Updated application properties to support environment variables for sensitive data and dynamic configurations, improving deployment flexibility.
• Docker Optimization: Added a docker-compose configuration and simplified the Docker entrypoint to rely on environment-driven configuration rather than hardcoded profile flags.

Ignored Files

• Ignored by pattern: .github/workflows/** (2)
  • .github/workflows/dev-cd.yml
  • .github/workflows/prod-cd.yml
• Ignored by pattern: docs/** (1)
  • docs/architecture/deployment-and-runtime-config.md

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the application configuration by removing the private profile and externalizing sensitive settings (JWT and AWS credentials) into environment variables across the dev, local, and prod profiles. It also introduces a docker-compose.yml file and updates the .gitignore and Dockerfile accordingly. The review feedback suggests making the .env file optional in docker-compose.yml to prevent build failures in environments where it is missing, and wrapping YAML property placeholders containing colons or commas in double quotes to avoid parsing issues.

[gemini-code-assist]

Since .env is added to .gitignore and might not exist in all environments (such as CI/CD pipelines or production environments where environment variables are injected directly), referencing it as a required env_file will cause docker compose to fail with an error.

Consider making the .env file optional by using the path and required: false syntax (supported in Docker Compose v2.24.0+).

    env_file:
      - path: .env
        required: false

[gemini-code-assist]

Unquoted property placeholders containing commas and colons (like URLs) can lead to parsing issues in YAML or unexpected behavior with Spring's property binder. It is safer and more robust to wrap the value in double quotes.

  allowed-origins: "${CORS_ALLOWED_ORIGINS:http://localhost:3000, https://dev.crew-wiki.site, https://dev.api.crew-wiki.site}"

[gemini-code-assist]

Unquoted property placeholders containing colons (like URLs) can sometimes cause parsing issues in YAML. Wrapping the value in double quotes ensures it is parsed correctly as a string literal.

  server-url: "${SWAGGER_SERVER_URL:https://dev.api.crew-wiki.site}"

[gemini-code-assist]

Unquoted property placeholders containing commas and colons (like URLs) can lead to parsing issues in YAML or unexpected behavior with Spring's property binder. It is safer and more robust to wrap the value in double quotes.

  allowed-origins: "${CORS_ALLOWED_ORIGINS:https://crew-wiki.site, https://api.crew-wiki.site}"

[gemini-code-assist]

Unquoted property placeholders containing colons (like URLs) can sometimes cause parsing issues in YAML. Wrapping the value in double quotes ensures it is parsed correctly as a string literal.

  server-url: "${SWAGGER_SERVER_URL:https://api.crew-wiki.site}"