fix(security): 2 improvements across 2 files#869
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Insecure Deserialization via pickle.load without Restrictions - Security: Hardcoded API Credentials in Source Code Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Insecure Deserialization via pickle.load without Restrictions - Security: Hardcoded API Credentials in Source Code Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Critical| File:RMS/Pickling.py:L46The
loadPicklefunction inRMS/Pickling.pyusespickle.load()to deserialize data from arbitrary file paths without any input validation or restrictions. Python's pickle module is not secure against maliciously constructed data. An attacker could craft a malicious pickle file that executes arbitrary code when loaded. The function catches exceptions but still processes untrusted input.Solution
Replace pickle with a safer serialization format like JSON for untrusted data, or implement strict input validation and consider using
pickleonly with trusted sources. If pickle must be used, consider usingpickle.loads()with a restricted unpickler or add a whitelist of allowed classes.Changes
RMS/Pickling.py(modified)RMS/ImgurUpload.py(modified)