Migrate ABViewGrid - #722
Merged
Merged
Conversation
benthongtiang
added
the
patch
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Lighthouse Performance ReportMetrics📄Full Report |
johnny-hausman
requested changes
May 18, 2026
johnny-hausman
left a comment
johnny-hausman
left a comment
Collaborator
There was a problem hiding this comment.
Rework those files into your plugin.
…ort, function or class' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ort, function or class' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ort, function or class' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ort, function or class' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ort, function or class' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ds component location
johnny-hausman
requested changes
May 26, 2026
johnny-hausman
left a comment
johnny-hausman
left a comment
Collaborator
There was a problem hiding this comment.
a few more updates
|
|
||
| try { | ||
| await CurrentObject.model().update(item.id, item); | ||
| await CurrentObject.model().update(item.id, patch); |
Collaborator
There was a problem hiding this comment.
are you sure we are supposed to be updating the smaller patch? That isn't what we were doing before.
Contributor
Author
There was a problem hiding this comment.
I found that sometimes updating the data fails when sending the entire item. I using patch because it only updates the modified field. Let me know what you think.
johnny-hausman
approved these changes
May 29, 2026
johnny-hausman
left a comment
johnny-hausman
left a comment
Collaborator
There was a problem hiding this comment.
Alright, lets give this a try!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated the Grid View to the new plugin architecture and resolved a critical crash in the List data field when handling empty selections.
Relate PR.
CruGlobal/plugin_ABDesigner#349
CruGlobal/appbuilder_class_core#343