Skip to content

Resolve potential undefined errors by normalizing data types. #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benthongtiang merged 2 commits into from
Jul 23, 2026
Merged

Resolve potential undefined errors by normalizing data types. #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75c4214
Resolve potential undefined errors by normalizing data types and addi…
benthongtiang Jul 23, 2026
b12f5d6
Provide the code changes or file diffs you would like me to summarize.
benthongtiang Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AppBuilder/core
Open in desktop
Submodule core updated from 03d420 to f6531c
3 changes: 2 additions & 1 deletion AppBuilder/platform/dataFields/ABFieldList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,10 @@ function _getSelectedOptions(field, rowData = {}) {

// Pull text with current language
if (field.settings) {
const resultArray = Array.isArray(result) ? result : [result];
result = (field.settings.options || []).filter((opt) => {
return (
(result || []).filter(
resultArray.filter(
(v) => opt && v && (opt.id || opt) == (v.id || v)
).length > 0
);
Expand Down
4 changes: 2 additions & 2 deletions AppBuilder/platform/plugins/ABClassUIPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export default class ABClassUIPlugin extends ClassUI {
get CurrentView() {
return this.CurrentApplication?.views(
(v) => v.id == this.CurrentViewID
)[0];
)?.[0];
}

/**
Expand All @@ -204,7 +204,7 @@ export default class ABClassUIPlugin extends ClassUI {
* icon: {string} the icon to display
*/
datacollectionsIncluded() {
return this.CurrentApplication?.datacollectionsIncluded()
return (this.CurrentApplication?.datacollectionsIncluded() || [])
.filter((dc) => {
const obj = dc.datasource;
return (
Expand Down
Loading