Skip to content

Migrate ABViewGrid #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benthongtiang merged 4 commits into from
Jun 1, 2026
Merged

Migrate ABViewGrid #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c747e1c
Ccomment out ABViewGrid import in ABViewManagerCore
benthongtiang Apr 29, 2026
a87c916
Merge remote-tracking branch 'origin/v2' into ben/grid
benthongtiang May 14, 2026
76a1d2c
Merge remote-tracking branch 'origin/v2' into ben/grid
benthongtiang May 26, 2026
f032964
Prevent console errors for [object Object] values during JSON parsing…
benthongtiang May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ABModelCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,7 @@ module.exports = class ABModelCore {
row[f.columnName] = JSON.parse(val);
} catch (e) {
// sometimes "list" fields are not JSON parseable
if (f.key != "list") {
if (f.key != "list" && val !== "[object Object]") {
console.error(
"Error parsing JSON data for column: " + f.columnName,
val,
Expand Down
2 changes: 1 addition & 1 deletion ABViewManagerCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var AllViews = [
// require("../platform/views/ABViewDataSelect"),
require("../platform/views/ABViewDataview"),
require("../platform/views/ABViewDocxBuilder"),
require("../platform/views/ABViewGrid"),
// require("../platform/views/ABViewGrid"),
// require("../platform/views/ABViewImage"),
// require("../platform/views/ABViewLabel"),
// require("../platform/views/ABViewLayout"),
Expand Down
Loading