Skip to content

Hide 'Last Updated' for offline organizations #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbirdjavi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hide 'Last Updated' for offline organizations #1939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/Settings/integrations/Organization/OrganizationAccordion.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ describe('OrganizationAccordion', () => {
getByText(GetUsersOrganizationsAccountsMock[0].organization.name),
).toBeInTheDocument();

expect(getByText('Last Updated')).toBeInTheDocument();
// Offline orgs never download, so a "Last Updated" timestamp is
// meaningless for them and must not be shown; "Last Gift Date" is the
// honest signal and stays.
expect(queryByText('Last Updated')).not.toBeInTheDocument();

expect(getByText('Last Gift Date')).toBeInTheDocument();
});
Expand Down Expand Up @@ -237,6 +240,9 @@ describe('OrganizationAccordion', () => {
expect(
queryByText('Import TntConnect DataSync file'),
).not.toBeInTheDocument();

// Non-offline orgs really do download, so "Last Updated" stays.
expect(getByText('Last Updated')).toBeInTheDocument();
});

userEvent.click(getByText('Sync'));
Expand Down
2 changes: 1 addition & 1 deletion src/components/Settings/integrations/Organization/OrganizationAccordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ export const OrganizationAccordion: React.FC<AccordionProps> = ({
</Box>
</Box>
<Divider />
{lastDownloadedAt && (
{type !== OrganizationTypesEnum.OFFLINE && lastDownloadedAt && (
<Box sx={{ p: 2, display: 'flex' }}>
<Grid
container
Expand Down
Loading