Fix/okr author#146
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and testing of author name processing in the World Bank OKR plugin. The main changes include enhancing the
_process_authorsmethod to better handle single-author cases and adding a corresponding test to ensure correctness.Enhancements to author name processing:
_process_authorsmethod inworld_bank_okr.pyto handle cases where an author string does not contain a comma, ensuring single-author names like "World Bank" are processed correctly.Testing improvements:
test__process_authors_one_authorintest_world_bank_okr.pyto verify that single-author inputs are correctly processed by_process_authors.