fix: improve error handling in WorldBankOKRRecord model validation#147
Open
lpi-tn wants to merge 1 commit into
Open
fix: improve error handling in WorldBankOKRRecord model validation#147lpi-tn wants to merge 1 commit into
lpi-tn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness and test coverage of the
WorldBankOKRRecordmodel by adding validation for missing or malformed XML fields and expanding the test suite to cover these scenarios. The main changes are grouped into enhanced validation logic and expanded test coverage.Enhanced validation logic:
_extract_file_grpinworld_bank_okr.pyto raise aValueErrorwith a descriptive message if thefileGrporFLocattags are missing from the XML input, improving error reporting for malformed documents._extract_identifiersto raise aValueErrorwhen no URI identifier is found, ensuring required fields are present.support_xml_extractorto raise aValueErrorwith clear messages iftitleorabstracttags are missing, replacing custom exceptions for consistency and clarity. [1] [2]Expanded test coverage:
test_world_bank_okr.pyto verify that the model correctly raisesValidationErrorwhen required XML fields (fileGrp,FLocat,identifier,title,abstract) are missing or empty, ensuring the validation logic works as intended.ValidationErrorfrompydanticin the test file to support the new test cases.