Security improvements to docker deployment#32
Open
shadyeip wants to merge 4 commits into
Open
Conversation
shadyeip
commented
Sep 22, 2024
- Added reverse proxy to forward 443 to 5000.
- Updated app services to bind to localhost, only exposing reverse proxy to the host.
- Added self-signed cert generation.
- Added ability to use custom certs. Simply create a directory called certs in the nginx directory, and add cert (nginx.crt) and key (nginx.key) to it.
Collaborator
|
Hi @shadyeip Thanks for the PR! Looks like some awesome improvements. We will review and aim to merge ASAP. |
Author
|
There's a bug in nginx conf file that prevents screenshot uploads, I'll push a fix when I get a chance. Otherwise, this has been working well for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.