KillCharacter() is evil from within CCharacter because it deletes this

ChillerDragon · ChillerDragon · commit cc3bad6c0f32 · 2025-01-06T09:17:28.000+01:00
Thats how you get nasty bugs
diff --git a/src/server/ddnet_callback_ctx.cpp b/src/server/ddnet_callback_ctx.cpp
@@ -26,7 +26,8 @@ void CDDNetCallbackCtx::Die()
 	if(!pPlayer)
 		return;
 
-	pPlayer->KillCharacter(WEAPON_SELF);
+	if(pPlayer->GetCharacter())
+		pPlayer->GetCharacter()->Die(pPlayer->GetCid(), WEAPON_SELF);
 }
 
 void CDDNetCallbackCtx::Emote(int Emoticon)

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,8 @@ void CDDNetCallbackCtx::Die()`
`26`	`26`	`if(!pPlayer)`
`27`	`27`	`return;`
`28`	`28`
`29`		`- pPlayer->KillCharacter(WEAPON_SELF);`
	`29`	`+ if(pPlayer->GetCharacter())`
	`30`	`+ pPlayer->GetCharacter()->Die(pPlayer->GetCid(), WEAPON_SELF);`
`30`	`31`	`}`
`31`	`32`
`32`	`33`	`void CDDNetCallbackCtx::Emote(int Emoticon)`