gui/petition: fix deity display#1586
Open
chdoc wants to merge 1 commit into
Open
Conversation
Member
Author
|
@SilasD Would you be willing to take a look at this? |
SilasD
reviewed
May 16, 2026
Contributor
SilasD
left a comment
SilasD
left a comment
There was a problem hiding this comment.
this looks fine except for future-proofing in case a third option is added to the
df.religious_practice_type. which realistically ain't gonna happen.
It should resolve the issue. I'm fine with it.
| local hf = df.historical_figure.find(practice_id) | ||
| if not hf then return 'An Unknown Deity' end | ||
| return dfhack.translation.translateName(hf.name, true) | ||
| else |
Contributor
There was a problem hiding this comment.
like this could be
elseif practice_type == df.religious_practice_type.RELIGION_ENID then
(untested code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: DFHack/dfhack#5686
Disclaimer: I am following the structure of the types here, I don't actually have a petition from an organization that doesn't worship a religion but directly worships a deity.