chore: drop print() from production lib/, harden analyze to --fatal-infos

.github/workflows/pull-request.yaml

@@ -21,7 +21,7 @@ jobs:
           cache: true
       - run: flutter pub get
       - run: dart format --set-exit-if-changed --output=none lib test example/lib example/test
-      - run: flutter analyze --no-fatal-infos
+      - run: flutter analyze --fatal-infos
       - run: flutter test
 
   go:

TESTING.md

@@ -8,7 +8,7 @@ these, so it is cheaper to catch them locally first:
 ```sh
 # Flutter
 dart format --set-exit-if-changed --output=none lib test example/lib example/test
-flutter analyze --no-fatal-infos
+flutter analyze --fatal-infos
 flutter test
 
 # Go (from go/)

example/lib/main.dart

@@ -1,3 +1,7 @@
+// Demo app uses print() for runtime console feedback during the BitBox flow
+// walkthrough. The plugin itself (lib/) must stay print-free.
+// ignore_for_file: avoid_print
+
 import 'dart:async';
 import 'dart:convert';
 import 'dart:ffi';

lib/usb/bitbox_usb_method_channel.dart

@@ -39,12 +39,10 @@ class MethodChannelBitboxUsb extends BitboxUsbPlatform {
 
   @override
   Future<bool> open(BitboxDevice usbDevice) async {
-    print('[bitbox_flutter] open ${usbDevice.productName}');
     final open = await methodChannel.invokeMethod<bool>(
       'open',
       usbDevice.toMap(),
     );
-    print('[bitbox_flutter] open $open');
 
     return open ?? false;
   }
@@ -58,9 +56,7 @@ class MethodChannelBitboxUsb extends BitboxUsbPlatform {
 
   @override
   Future<bool> initBitBox() async {
-    print('[bitbox_flutter] initBitBox');
     final result = await methodChannel.invokeMethod<bool>('initBitBox');
-    print('[bitbox_flutter] initBitBox $result');
 
     return result ?? false;
   }