test: seed initial Modal visual regression baselines#1095
Closed
TaprootFreak wants to merge 1 commit into
Closed
Conversation
Six baseline PNGs (3 stories × 2 viewports) captured on the Linux CI runner after the serve.json + snapshotPathTemplate fix (#1094) made the Storybook stories actually render under the visual test harness. Sanity checks: - modal-default-* and modal-fullscreen-* are byte-identical at every viewport. That is the load-bearing property: any future PR that silently flips the Modal default away from fullscreen (as PR #1048 did) will diverge these two snapshots and fail the gate. - modal-dialog-* shows the centered card on the translucent backdrop, distinct from the fullscreen variant. Captured by https://github.com/DFXswiss/services/actions/runs/25744377295
Collaborator
Author
|
Schliessen statt mergen — Decorator und Stories werden in einem Folge-PR robuster gemacht (deterministischer topOffset, realistischer Story-Inhalt, expliziter Wait im Spec). Die Baselines hier wären nach diesen Änderungen sowieso obsolet. Finale Baselines kommen als separater stacked PR nach dem Improvement-PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1093 (parent), follow-up to merged #1094 (rendering fixes).
What
Six baseline PNGs captured by the Linux CI runner after the serve.json + snapshotPathTemplate fix from #1094 made the stories render correctly:
modal-default-desktop.png/modal-default-mobile.pngmodal-fullscreen-desktop.png/modal-fullscreen-mobile.pngmodal-dialog-desktop.png/modal-dialog-mobile.pngSource: Actions run #25744377295, the first one to run with the fixes applied.
Sanity checks before committing
The byte-identity of `Default` and `Fullscreen` is the load-bearing property of this guard: any future PR that silently flips the Modal default away from fullscreen (as PR #1048 did) will diverge these two snapshots and fail CI before merge.
What happens after merge into #1093
Next CI run on #1093 finds the baselines in `e2e/storybook/snapshots/modal-visual.spec.ts/`, runs the 6 tests against them, all pass → `Storybook visual regression` check turns green → the gate is live and #1093 is ready for review.