Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR aims at fixing the following bug:
Running a hierarchical greedy or simulated annealing algorithm to find the best MCM for a given dataset after running it for another dataset with the same MCMSearch object yields incorrect results.
The problem was that the evidence storage that keeps track of the log-evidence for ICCs that have already been calculated during the search was not cleared after the search. When running a search for a second dataset the log-evidence for certain ICCs was not recalculated because they were still stored from the last search.
This issue is fixed by clearing the storage after each search.