Enable additional DPDK drivers#619
Merged
Merged
Conversation
This comment was marked as low quality.
This comment was marked as low quality.
Collaborator
Author
|
Hi @appliedprivacy, once the build is complete: https://github.com/DPDK/grout/actions/runs/26059436089/job/76615573217 Can you download the If it does, please report back with a comment: Thanks! |
david-marchand
approved these changes
May 19, 2026
Member
david-marchand
left a comment
david-marchand
left a comment
There was a problem hiding this comment.
On the principle, the series looks good to me.
Collaborator
Author
|
Tested-by: Christoph cm@appliedprivacy.net |
The case() expression function is not supported in the runs-on field which is evaluated at workflow dispatch time with a limited expression parser. This causes the entire workflow to fail validation, preventing any jobs from running on pull requests. Use the ternary pattern (condition && value || default) which is already used successfully in check.yml for the same purpose. Fixes: e57cea2 ("ci: simplify rpm job matrix") Signed-off-by: Robin Jarry <rjarry@redhat.com> Tested-by: Christoph <cm@appliedprivacy.net> Reviewed-by: David Marchand <david.marchand@redhat.com>
Instead of opaque comma separated strings, use meson lists and join them before passing to the DPDK subproject default arguments. Signed-off-by: Robin Jarry <rjarry@redhat.com> Tested-by: Christoph <cm@appliedprivacy.net> Reviewed-by: David Marchand <david.marchand@redhat.com>
Enable additional drivers to support more NICs. Link: https://mails.dpdk.org/archives/grout/2026-May/000041.html Requested-by: Christoph <cm@appliedprivacy.net> Signed-off-by: Robin Jarry <rjarry@redhat.com> Tested-by: Christoph <cm@appliedprivacy.net> Reviewed-by: David Marchand <david.marchand@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable additional drivers to support more NICs.
Link: https://mails.dpdk.org/archives/grout/2026-May/000041.html
meson.build
.github/workflows/package.yml