Add debug utilities to help debug dynamic lights and small fixes#1908
Open
DolceTriade wants to merge 4 commits intoDaemonEngine:masterfrom
Open
Add debug utilities to help debug dynamic lights and small fixes#1908DolceTriade wants to merge 4 commits intoDaemonEngine:masterfrom
DolceTriade wants to merge 4 commits intoDaemonEngine:masterfrom
Conversation
This adds a debug cvar to draw a tetrahedron (similar to what you get when yuou enable r_showSkeleton) in the direction of a spot light or in 6 directions for an omnilight that is proportional to the radius of the light. This makes it easier to visualize dynamic lights and see what they should be doing, what direction they are intended to point, etc. Also, while here, normalize spotlight direction.
Makes it easier to test dynamic lights.
Using git bisect, e497a08 introduces a window where globalUBOProxy can be null after glsl_restart. Therefore, also return early, if glboalUBOProxy is null. It will be instantiated later. Further, only initialize world shaders *AFTER* all shader storage has been initiialized.
Directional lights should affect all light tiles, so automatically add them to every tile since we don't populate the radius. Also add some cvars to allow adding a debug sun.
slipher
reviewed
Mar 30, 2026
| { | ||
| static const vec3_t kOmniDirs[ 6 ] = { | ||
| { 1.0f, 0.0f, 0.0f }, | ||
| { -1.0f, 0.0f, 0.0f }, |
| }; | ||
| for ( int dirIndex = 0; dirIndex < 6; ++dirIndex ) | ||
| { | ||
| addArrow( kOmniDirs[ dirIndex ], color ); |
Member
There was a problem hiding this comment.
The 12 tetrahedrons seems too busy to me. Maybe we could just draw a wireframe cube?
| glState.modelViewProjectionMatrix[ glState.stackIndex ] ); | ||
|
|
||
| Tess_Begin( Tess_StageIteratorDebug, nullptr, true, -1, 0 ); | ||
| GL_CheckErrors(); |
| light->color[ 0 ] = r_debugProjLightR.Get(); | ||
| light->color[ 1 ] = r_debugProjLightG.Get(); | ||
| light->color[ 2 ] = r_debugProjLightB.Get(); | ||
| light->scale = r_debugProjLightIntensity.Get(); |
Member
There was a problem hiding this comment.
This doesn't compile since scale was removed on the for-0.56 branch. Now it's just unbounded r/g/b values.
| } | ||
|
|
||
| // Debug spot light (projected) injection | ||
| static Cvar::Cvar<bool> r_debugProjLight( "r_debugProjLight", "inject a directional sun light each frame", Cvar::NONE, false ); |
|
|
||
| static void AddDebugProjectedLight() | ||
| { | ||
| if ( r_numLights + 1 >= MAX_REF_LIGHTS ) |
| for( uint i = uint( u_lightLayer ); i < uint( u_numLights ); i += uint( NUM_LIGHT_LAYERS ) ) { | ||
| Light l = GetLight( i ); | ||
| // Directional lights (sun) have infinite extent, so always include them in tiles | ||
| if ( l.type == 2 ) { |
Member
There was a problem hiding this comment.
Instead of this how about setting a large radius in the code that adds the light?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glsl_restart