feat(conversation): enforce Slack MPIM participant limit (max 7 + bot)#61
Closed
xergioalex wants to merge 1 commit into
Closed
feat(conversation): enforce Slack MPIM participant limit (max 7 + bot)#61xergioalex wants to merge 1 commit into
xergioalex wants to merge 1 commit into
Conversation
Slack group DMs (MPIMs) support at most 8 total members. Since the Dailybot bot always occupies one slot, `conversation open` now rejects more than 7 user participants client-side before hitting the API. - Add MAX_CONVERSATION_PARTICIPANTS constant (7) - Pre-check identifier count and post-dedup UUID count - Handle `conversation_too_many_participants` API error code - Document the limit in the vendored agent skill Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
Merged into PR #60 — all changes consolidated into a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversation openthat rejects >7 participants immediately (both before and after dedup/resolution).conversation_too_many_participantsAPI error code with a user-friendly message.conversation/SKILL.md).Test plan
dailybot conversation open -u u1 -u u2 ... -u u8(8 users) → rejected client-side with clear errordailybot conversation open -u u1 ... -u u7(7 users) → allowed through400 conversation_too_many_participants→ CLI shows friendly messagedailybot conversation open --helprenders cleanlypytestpasses (565/566 — 1 pre-existing unrelated failure)Made with Cursor