Simple Galaxy Gate: Updated ABG gate IDs to reverse order (Gamma → Beta → Alpha).#174
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReorders the ABG gate IDs to iterate Gamma → Beta → Alpha instead of Alpha → Beta → Gamma, and clarifies comments to reflect that ABG IDs are treated as a special wildcard group for map lookup and travel routing. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- If the iteration order of
ABG_IDSis now significant (Gamma → Beta → Alpha), consider either renaming the constant or expanding the comment to state explicitly that the list is ordered by priority to make this dependency clear to future readers. - The special handling for map ID 0 as an ABG wildcard is currently split between
MapsandSimpleGalaxyGate; consider centralizing this logic (e.g., a helper inMaps) so the behavior for ID 0 cannot drift between call sites.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If the iteration order of `ABG_IDS` is now significant (Gamma → Beta → Alpha), consider either renaming the constant or expanding the comment to state explicitly that the list is ordered by priority to make this dependency clear to future readers.
- The special handling for map ID 0 as an ABG wildcard is currently split between `Maps` and `SimpleGalaxyGate`; consider centralizing this logic (e.g., a helper in `Maps`) so the behavior for ID 0 cannot drift between call sites.
## Individual Comments
### Comment 1
<location path="src/main/java/dev/shared/do_gamer/module/simple_galaxy_gate/config/Maps.java" line_range="35" />
<code_context>
}
- public static final List<Integer> ABG_IDS = List.of(51, 52, 53); // Alpha, Beta, Gamma gate IDs
+ public static final List<Integer> ABG_IDS = List.of(53, 52, 51); // Gamma, Beta, Alpha gate IDs
private static List<MapInfo> ggMaps;
private static double mapCenterX = Defaults.MAP_CENTER_X;
</code_context>
<issue_to_address>
**issue (bug_risk):** Reversing ABG_IDS ordering may break any callers that rely on positional semantics instead of set membership.
Any positional access like `ABG_IDS.get(0)` will now return Gamma instead of Alpha. In this file you only use `contains`, so order doesn’t matter here, but please either (a) rename this to make the ordering/priority explicit (e.g. `ABG_PRIORITY_ORDER`), or (b) search for and verify any index-based uses of `ABG_IDS` elsewhere still behave correctly after this change.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
@dm94 Tested and ready to merge. |
dm94
approved these changes
Jun 23, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary by Sourcery
Reverse the configured ABG gate ID order and clarify ABG-related comments to better reflect the special handling of these gates.
Enhancements: