Charger connected state is true true when connected

[DasBasti]

Charger connection state is a boolean value. So it is moved to the binary sensors.

Summary by CodeRabbit

• New Features

  • Introduced a new binary sensor that indicates whether the charger is connected, with an updated icon and device class for easier identification.

• Bug Fixes

  • Adjusted unit handling for charger connection status sensors to ensure correct display and consistency.

• Refactor

  • Removed the previous sensor entry for charger connection status, consolidating functionality under the new binary sensor.

[coderabbitai]

Walkthrough

A new binary sensor for charger connection status was added to the binary sensor entities, while the corresponding standard sensor entry was removed. Additionally, logic was updated to ensure no unit of measurement is shown for charger connection status sensors. No other structural or control flow changes were introduced.

Changes

File(s)	Change Summary
custom_components/smarthashtag/binary_sensor.py	Added a binary sensor entity description for is_charger_connected to the LOCK_ENTITIES tuple.
custom_components/smarthashtag/sensor.py	Removed is_charger_connected from battery sensor descriptions and updated unit logic for charger connection status.

Poem

A charger is plugged, the sensor now knows,
With a binary wink, its status it shows.
Old sensor retired, no unit to see—
Just a simple connection, as clear as can be!
🐇🔌✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce35328 and 9206e98.

📒 Files selected for processing (2)

• custom_components/smarthashtag/binary_sensor.py (1 hunks)
• custom_components/smarthashtag/sensor.py (1 hunks)

🔇 Additional comments (2)

custom_components/smarthashtag/sensor.py (1)

1101-1102: LGTM! Consistent unit handling for status sensors.

The addition of the conditional check for "charger_connection_status" follows the established pattern used for "charging_status" sensors and correctly returns None for enum-type sensors that don't have units of measurement.

custom_components/smarthashtag/binary_sensor.py (1)

141-148:

Details

❓ Verification inconclusive

LGTM! Well-implemented binary sensor for charger connection.

The new binary sensor follows established patterns in the codebase with appropriate device class, icon, and naming. The distinction between the existing charger_connection_status (enum) and the new is_charger_connected (boolean) sensors is clear and appropriate.

Please verify that the data source state.battery.is_charger_connected is reliably available and returns a boolean value to ensure the sensor functions correctly.

---

🏁 Script executed:

#!/bin/bash
# Search for usage of is_charger_connected in the codebase to verify data source
rg -A 3 -B 3 "is_charger_connected"

Length of output: 2080

---

🏁 Script executed:

#!/usr/bin/env bash
set -euxo pipefail
# 1. Show all contexts where state.battery is used
rg -A3 -B3 "state\.battery"
# 2. List python files (excluding binary_sensor.py) that reference battery to locate model/parsing code
rg "battery" -g "*.py" | grep -v "binary_sensor.py" | sed 's/:.*//g' | sort -u

Length of output: 796

---

🏁 Script executed:

#!/usr/bin/env bash
set -euxo pipefail

# 1. Show the first 200 lines of __init__.py to find coordinator setup and state definition
sed -n '1,200p' custom_components/smarthashtag/__init__.py

# 2. Find any class definitions for State in the smarthashtag component
rg -n "class .*State" -g "custom_components/smarthashtag/*.py"

# 3. Show battery-related parsing logic in sensor.py for context
rg -n -C3 "battery" -g "custom_components/smarthashtag/sensor.py"

# 4. Check for update_data in the coordinator to see where raw data comes from
rg -n -C3 "async_update_data" -g "custom_components/smarthashtag/*.py"

Length of output: 4231

---

LGTM! Well-implemented binary sensor for charger connection.

The new binary sensor follows established patterns in the codebase with appropriate device class, icon, and naming. The distinction between the existing charger_connection_status (enum) and the new is_charger_connected (boolean) sensors is clear and appropriate.

Please manually verify that the property state.battery.is_charger_connected is defined by the data update coordinator (or the underlying library) and reliably returns a boolean value to ensure the sensor functions correctly.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
smarthashtag
__init__.py	18	1	94%	107
binary_sensor.py	27	0	100%
climate.py	105	30	71%	128–129, 133, 136–137, 140, 144, 147–148, 151, 155–158, 162–165, 167–168, 177, 181, 185, 189, 193, 197, 201, 205, 209, 213
config_flow.py	54	12	77%	57–59, 97, 136, 154, 170, 184–186, 188, 216
const.py	34	0	100%
coordinator.py	52	17	67%	60–67, 90–97, 120
device_tracker.py	49	0	100%
entity.py	15	2	86%	48–49
select.py	59	14	76%	112–113, 121–122, 130–131, 134–138, 141, 158–159
sensor.py	223	40	82%	1077, 1084–1085, 1088, 1135–1136, 1139, 1180–1181, 1190, 1198, 1201, 1207, 1210–1211, 1214, 1222–1223, 1230, 1277–1278, 1281, 1309, 1311–1312, 1315, 1358–1359, 1362, 1394–1397, 1401–1403, 1405–1406, 1409, 1421
TOTAL	636	116	81%

[DasBasti]

This is a breaking change so we need to wait until we can merge this.