Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4831 +/- ##
===========================================
- Coverage 74.55% 74.53% -0.03%
===========================================
Files 166 166
Lines 14633 14633
Branches 1164 1164
===========================================
- Hits 10910 10907 -3
- Misses 3723 3726 +3 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have to do this hacky thing because the current way we're installing jupyter server extension assumes we also need to install the package (see this)
This won't work for qiime, because it's not installed via pip.
The other thing is we needed to upgrade jupyter-server in order to enable qimme server extension.
TODO: test
Jira ticket: https://precisionmedicineinitiative.atlassian.net/browse/RW-12661
Summary of changes
What
Why
Testing these changes
What to test
Who tested and where
jenkins retestorjenkins multi-test.