add additional ethtool counters for metric collection

[steveny91]

What does this PR do?

Adds more metrics to be collected with ethtool collection in the network check. I wanted to add this to the python, but then realized this was migrated over to Go:
DataDog/integrations-core#23884

Motivation

More metric coverage especially for the Mellanox drivers. Derived mostly from the kernel docs:
https://docs.kernel.org/networking/device_drivers/ethernet/mellanox/mlx5/counters.html

[github-actions]

@codex review

[datadog-prod-us1-3]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/datadog-agent | oracle: [21.3.0-xe]     

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.

Failed to ping oracle instance: ORA-12514: TNS:listener does not currently know of service requested in connect descriptor

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 50.63% (+0.15%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f591011 | Docs | Datadog PR Page | Give us feedback!}

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[github-actions]

@codex review

[github-actions]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 3d9e11e6:

Results for datadog-agent_7.81.0~devel.git.347.f591011.pipeline.116033646-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3d9e11e
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	N/A	N/A → 746.315 → 750.800
✅	agent_deb_amd64_fips	N/A	N/A → 704.073 → 704.300
✅	agent_heroku_amd64	N/A	N/A → 310.774 → 314.260
✅	agent_rpm_amd64	N/A	N/A → 746.298 → 750.770
✅	agent_rpm_amd64_fips	N/A	N/A → 704.057 → 704.300
✅	agent_rpm_arm64	N/A	N/A → 723.842 → 724.500
✅	agent_rpm_arm64_fips	N/A	N/A → 684.770 → 684.870
✅	agent_suse_amd64	N/A	N/A → 746.298 → 750.770
✅	agent_suse_amd64_fips	N/A	N/A → 704.057 → 704.300
✅	agent_suse_arm64	N/A	N/A → 723.842 → 724.500
✅	agent_suse_arm64_fips	N/A	N/A → 684.770 → 684.870
✅	docker_agent_amd64	N/A	N/A → 806.451 → 806.840
✅	docker_agent_arm64	N/A	N/A → 808.820 → 810.120
✅	docker_agent_jmx_amd64	N/A	N/A → 997.371 → 997.600
✅	docker_agent_jmx_arm64	N/A	N/A → 988.518 → 989.800
✅	docker_cluster_agent_amd64	N/A	N/A → 207.109 → 207.710
✅	docker_cluster_agent_arm64	N/A	N/A → 221.078 → 221.210
✅	docker_cws_instrumentation_amd64	N/A	N/A → 7.154 → 7.190
✅	docker_cws_instrumentation_arm64	N/A	N/A → 6.689 → 6.920
✅	docker_dogstatsd_amd64	N/A	N/A → 39.519 → 39.560
✅	docker_dogstatsd_arm64	N/A	N/A → 37.690 → 38.080
✅	docker_host_profiler_amd64	N/A	N/A → 302.131 → 315.880
✅	docker_host_profiler_arm64	N/A	N/A → 313.655 → 327.470
✅	dogstatsd_deb_amd64	N/A	N/A → 30.174 → 30.790
✅	dogstatsd_deb_arm64	N/A	N/A → 28.296 → 29.290
✅	dogstatsd_rpm_amd64	N/A	N/A → 30.174 → 30.790
✅	dogstatsd_suse_amd64	N/A	N/A → 30.174 → 30.790
✅	iot_agent_deb_amd64	N/A	N/A → 44.476 → 45.230
✅	iot_agent_deb_arm64	N/A	N/A → 41.441 → 42.800
✅	iot_agent_deb_armhf	N/A	N/A → 42.154 → 42.960
✅	iot_agent_rpm_amd64	N/A	N/A → 44.477 → 45.230
✅	iot_agent_suse_amd64	N/A	N/A → 44.477 → 45.230

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b86c2451-e234-496f-ac0c-20f093eba277

Baseline: ca066ae
Comparison: f591011
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.30	[-1.67, +4.27]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.30	[-1.67, +4.27]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.66	[+0.48, +0.84]	1	Logs
➖	quality_gate_idle	memory utilization	+0.45	[+0.40, +0.50]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	+0.36	[+0.17, +0.56]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.35	[+0.19, +0.52]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.30	[+0.14, +0.46]	1	Logs
➖	ddot_logs	memory utilization	+0.26	[+0.21, +0.31]	1	Logs
➖	file_tree	memory utilization	+0.23	[+0.18, +0.28]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.12	[-0.06, +0.30]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.07	[+0.03, +0.10]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	+0.02	[-1.00, +1.04]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.01	[-0.04, +0.05]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.09, +0.10]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.00	[-0.20, +0.20]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.20, +0.20]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.03	[-0.54, +0.48]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.03	[-0.26, +0.20]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.03	[-0.43, +0.37]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.03	[-0.18, +0.12]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.06	[-0.51, +0.39]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.30	[-0.40, -0.19]	1	Logs
➖	docker_containers_memory	memory utilization	-0.33	[-0.43, -0.23]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-1.75	[-2.00, -1.50]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	598 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	246.67MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	646 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.18GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	145.07MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	740.59KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	476.36MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	174.88MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.33MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	348.81 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	378.10MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

[pgimalac]

Do we always want to emit those metrics or should they be behind a config flag ?

[pgimalac]

Actually this is already behind collect_ethtool_metrics which is false by default so should be fine

[steveny91]

@pgimalac Thanks for taking a look! I think it already behind a flag. I also added a new on in the network check spec here:
https://github.com/DataDog/integrations-core/pull/23884/changes

Under a new drive. I believe the python is where the conf.yaml gets generated from? If it isn't feel free to let me know where it is.

[pgimalac]

The config file on the Go side is https://github.com/DataDog/datadog-agent/blob/main/cmd/agent/dist/conf.d/network.d/conf.yaml.default, it's hardcoded, changing integrations-core doesn't impact it

[steveny91]

Gotcha. Do I just update that template you linked and it will be shipped with the agent?

Also this flag here:
https://github.com/DataDog/datadog-agent/blob/main/cmd/agent/dist/conf.d/network.d/conf.yaml.default#L40-L46

Is this still accurate? Reading this, it seems like it uses the Ethtool binary, but looking at the code it doesn't seem like the case anymore?