fix: Update tag setting to use addEnvironment API#600
Closed
samchungy wants to merge 2 commits into
Closed
Conversation
This was referenced May 10, 2026
Contributor
Author
|
Sorry I'm not too sure how to use projen - not sure how to bump the dev dep but keep the peer dep the same version |
Contributor
|
Thanks for opening this PR, this was ultimately resolved with #601 and https://github.com/DataDog/datadog-cdk-constructs/releases/tag/v2-4.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #596
Motivation
My CI is broken: https://github.com/seek-oss/skuba/actions/runs/25618922361/job/75201906880
Testing Guidelines
yarn test.yarn testto verify backwards compatibilityAdditional Notes
Unlike the other PRs, this isn't vibe coded...
This PR handles both older versions of aws-cdk-lib and newer versions but if you'd prefer a cleaner interface you can view the breaking change alternative here: #601
Types of Changes
Check all that apply